Skip to content

feat: disable product cookie when no targeting is set#1066

Closed
jaissica12 wants to merge 8 commits into
feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-storefrom
feat/SDKE-92-disable-product-cookie-when-noTargeting-is-set
Closed

feat: disable product cookie when no targeting is set#1066
jaissica12 wants to merge 8 commits into
feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-storefrom
feat/SDKE-92-disable-product-cookie-when-noTargeting-is-set

Conversation

@jaissica12

@jaissica12 jaissica12 commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Updated persistence logic to check noTargeting anytime cart products are read/written.
  • Added tests when noTargeting is true, false and default (false)

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 changed the base branch from feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-store to development September 16, 2025 01:22
@jaissica12 jaissica12 changed the base branch from development to feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-store September 16, 2025 01:32
@jaissica12 jaissica12 force-pushed the feat/SDKE-92-disable-product-cookie-when-noTargeting-is-set branch from 43345a3 to c624db9 Compare September 16, 2025 13:32
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
36.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jaissica12 jaissica12 changed the base branch from feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-store to development September 16, 2025 13:34
@jaissica12 jaissica12 changed the base branch from development to feat/SDKE-69-add-noFunctional-noTargeting-privacy-flags-in-store September 16, 2025 13:37
@jaissica12 jaissica12 closed this Sep 26, 2025
@jaissica12

Copy link
Copy Markdown
Contributor Author

Draft PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant